berkaysynnada commented on code in PR #17684:
URL: https://github.com/apache/datafusion/pull/17684#discussion_r2366343068
##########
datafusion/physical-plan/src/windows/mod.rs:
##########
@@ -471,7 +501,7 @@ pub(crate) fn window_equivalence_properties(
.get_aggregate_expr()
.expressions()
.into_iter()
- .map(sort_options_resolving_constant)
+ .map(|expr| sort_options_resolving_constant(expr,
false))
.multi_cartesian_product();
Review Comment:
Yes, this part is for calculating orderings of function results, and similar
approach can also be applied here. If you think the partitioning expr update
reasonable now, I'll apply the same here as well, in addition to the valid
parts of your PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
