Jefffrey commented on issue #18881: URL: https://github.com/apache/datafusion/issues/18881#issuecomment-3650150620
> [@Jefffrey](https://github.com/Jefffrey) I looked into the reamining three and I think they don't require the changes. > > * `datafusion-proto`: We should keep the parquet `max_statistics_size` lint as `#[allow(deprecated)]` because the deprecation isn’t emitted in all builds, and using expect causes unfulfilled-lint failures; thre are no other changes needed. > > * `datafusion-pruning`: The two `#[allow(dead_code)]` in pruning predicates because they cover parquet-only code paths and would risk unfulfilled expectations when the feature is disabled. > > * `datafusion-session`: no allow/expect present. We should still apply the deny at their lib.rs level, and any exceptions we handle on a case by case basis, so I still expect PRs for these crates. But it sounds like these can be fixed if we ensure the lint is expected only when certain features are enabled, see: https://github.com/apache/datafusion/issues/18881#issuecomment-3567846975 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
