paleolimbot commented on code in PR #18136:
URL: https://github.com/apache/datafusion/pull/18136#discussion_r2624157325
##########
datafusion/expr/src/expr.rs:
##########
@@ -812,13 +821,20 @@ pub struct TryCast {
/// The expression being cast
pub expr: Box<Expr>,
/// The `DataType` the expression will yield
- pub data_type: DataType,
+ pub field: FieldRef,
Review Comment:
We could also implement this by adding a `metadata: FieldMetadata` field
rather than switching the `data_type` to a `FieldRef`. We mostly just switched
`DataType` to `FieldRef` in other places so that's what I did here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
