alamb commented on code in PR #19298:
URL: https://github.com/apache/datafusion/pull/19298#discussion_r2624429652
##########
datafusion/datasource/src/url.rs:
##########
@@ -908,6 +1141,83 @@ mod tests {
}
}
+ /// MockSession variant that accepts a custom RuntimeEnv (for cache
testing)
Review Comment:
I think this is a lot of boiler plate code just to add the ability to change
the runtime env
Would you be willing to just add a `Option<RuntimeEnv>` field to the
existing `MockSession`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
