Jefffrey commented on PR #19587: URL: https://github.com/apache/datafusion/pull/19587#issuecomment-3708080953
If you do intend to continue work on this, it would be preferable to keep this PR open (even if just in draft mode) so we don't lose discussion context. It's a commendable effort to pickup an issue and drive through any roadblocks that come up, but it makes easier for all of us if at least we ensure things like the basic test suite is passing locally before things are pushed to the PR & reviews asked (unless there is some greater structural changes that may need to be discussed). The repository does have a lot of extended tests which aren't exactly straightforward to run locally, but the expectation is that at least the basic test suite via `cargo test` is run which should be enough to give reasonable confidence the changes have indeed been tested against the wider codebase. See the following links for some reading: - https://datafusion.apache.org/contributor-guide/index.html - https://datafusion.apache.org/contributor-guide/testing.html That is to say; it makes it much easier for us if such checks are done before reviews are requested, which in turn makes it more likely for us to give a quick turnaround on review time, which benefits everyone involved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
