andygrove opened a new pull request, #3048:
URL: https://github.com/apache/datafusion-comet/pull/3048
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
N/A
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
This follows on from https://github.com/apache/datafusion-comet/pull/3017
and makes some minor code improvements.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
- use `trim_ascii` instead of custom trim logic
- use two loops in `do_parse_string_to_int_legacy` and remove mutable
`parse_sign_and_digits`
- expand criterion benchmark to cover all three eval modes
## How are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
```
cast_string_to_int/legacy/i32
time: [11.188 µs 11.244 µs 11.299 µs]
cast_string_to_int/legacy/i64
time: [10.512 µs 10.543 µs 10.574 µs]
cast_string_to_int/ansi/i32
time: [11.996 µs 12.536 µs 13.028 µs]
Found 5 outliers among 100 measurements (5.00%)
5 (5.00%) high mild
cast_string_to_int/ansi/i64
time: [9.9062 µs 9.9537 µs 10.001 µs]
cast_string_to_int/try/i32
time: [10.771 µs 10.795 µs 10.821 µs]
Found 3 outliers among 100 measurements (3.00%)
2 (2.00%) low mild
1 (1.00%) high mild
cast_string_to_int/try/i64
time: [12.013 µs 12.731 µs 13.469 µs]
Found 7 outliers among 100 measurements (7.00%)
3 (3.00%) high mild
4 (4.00%) high severe
cast_string_to_int/legacy_decimals/i32
time: [12.401 µs 12.462 µs 12.526 µs]
cast_string_to_int/legacy_decimals/i64
time: [11.106 µs 11.282 µs 11.515 µs]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
