andygrove commented on code in PR #3048:
URL: https://github.com/apache/datafusion-comet/pull/3048#discussion_r2666193787
##########
native/spark-expr/src/conversion_funcs/cast.rs:
##########
@@ -386,12 +386,13 @@ fn can_cast_from_decimal(
}
macro_rules! cast_utf8_to_int {
- ($array:expr, $eval_mode:expr, $array_type:ty, $cast_method:ident) => {{
+ ($array:expr, $array_type:ty, $parse_fn:expr) => {{
Review Comment:
Pass in the parsing function as a closure rather than passing in the eval
mode and then matching on that for each row.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
