adriangb commented on code in PR #19599:
URL: https://github.com/apache/datafusion/pull/19599#discussion_r2669058564


##########
datafusion/common/src/stats.rs:
##########
@@ -321,6 +321,13 @@ impl Statistics {
         }
     }
 
+    /// Returns the memory size in bytes.
+    pub fn heap_size(&self) -> usize {
+        // column_statistics + num_rows + total_byte_size
+        self.column_statistics.capacity() * size_of::<ColumnStatistics>()
+            + size_of::<Precision<usize>>() * 2

Review Comment:
   I think so, if we want to follow the trait in arrow, which I think according 
to https://github.com/apache/datafusion/pull/19599#discussion_r2658477799 was 
the conclusion of the next step? Do you plan on push a commit to do so?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to