mkleen commented on code in PR #19599:
URL: https://github.com/apache/datafusion/pull/19599#discussion_r2673923330


##########
datafusion/common/src/stats.rs:
##########
@@ -321,6 +321,13 @@ impl Statistics {
         }
     }
 
+    /// Returns the memory size in bytes.
+    pub fn heap_size(&self) -> usize {
+        // column_statistics + num_rows + total_byte_size
+        self.column_statistics.capacity() * size_of::<ColumnStatistics>()
+            + size_of::<Precision<usize>>() * 2

Review Comment:
   I tried that, but certain fields of datatypes are private, which are 
necessary for scalar values. There is no way around it other than to first add 
this to arrow-rs.
    
   e.g.:
   
   ```rust
   impl HeapSize for FixedSizeListArray {
       fn heap_size(&self) -> usize {
           self.data_type().heap_size() + // <- private
               self.values().heap_size() +
               self.nulls().unwrap().heap_size() + // <- private
               self.value_length().heap_size() +
               self.len().heap_size() // <- private
       }
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to