asolimando commented on code in PR #19957:
URL: https://github.com/apache/datafusion/pull/19957#discussion_r2722738030
##########
datafusion/datasource-parquet/src/metadata.rs:
##########
@@ -419,6 +424,7 @@ fn get_col_stats(
is_max_value_exact: &mut [Option<bool>],
is_min_value_exact: &mut [Option<bool>],
column_byte_sizes: &[Precision<usize>],
+ distinct_counts: &[Precision<usize>],
Review Comment:
Adopted `StatisticsAccumulators` as suggested, it feels better and I got rid
of the "too many arguments" warning suppression, addressed in
4833ef5cfe1928ab9bafdde1b510131a2f17a211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
