asolimando commented on code in PR #19957:
URL: https://github.com/apache/datafusion/pull/19957#discussion_r2727672710
##########
datafusion/datasource-parquet/src/metadata.rs:
##########
@@ -411,53 +415,6 @@ fn create_max_min_accs(
(max_values, min_values)
}
-fn get_col_stats(
Review Comment:
Yes, the `get_col_stats` ->
`StatisticsAccumulators::build_column_statistics()` change is purely a no-op
refactor keeping the same logic, it just encapsulates it as a method on the
struct instead of a standalone function due to the grown number of parameters
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
