adriangb commented on PR #20037: URL: https://github.com/apache/datafusion/pull/20037#issuecomment-3811662578
> Converter is not consumed, it can be reused, that is the core problem. It can also be reused across multiple threads, "reset depth" is broken from that perspective as well. I will make some changes to add the salt and make it even safer to re-use, as well as making it non Send. I will also make it non-default. I don't expect you to accept the changes just because of it, but I'd appreciate if you could consider them. If they still don't meet your bar for inclusion in DataFusion we can leave this as an open bug and we'll hack a fix in externally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
