adriangb commented on PR #20037: URL: https://github.com/apache/datafusion/pull/20037#issuecomment-3812596769
@milenkovicm I've pushed these changes mentioned above. In particular: 1. I removed recursion tracking. It now uses a cleaner approach of creating throwaway serializers/deserializers. 2. I made it robust to collisions even under API misuses as far as I can tell. Secifically sharing across threads is safe and combining multiple proto payloads from different serializations and deserializing together is safe (or at least the probability of a collision is vanishingly small). 3. I split out the caching stuff into it's own implementation. The default implementation is now unchanged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
