> } > - *list = g_list_prepend(*list, g_slice_dup(GtkTreeIter, iter)); > + > + gtk_tree_model_get(GTK_TREE_MODEL(store), iter, > SYMBOLS_COLUMN_TAG, &tag, -1);
I don't like looking up the store if it can be avoided. And IIUC it can, "just" needs to also receive the old tag as a second arg: in the first pass we already looked it up, and in the second it'll be the same. --- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/797/files#r48277009
