> shouldn't the entry be removed if list==NULL like it used to do? Yeah, I guess it makes sense (I've updated the patch). On the other hand as the removal will cause re-balancing the tree so the potential performance gained by making the tree smaller will be offset by the rebalancing. We could also remove the item from the hash table if the whole tree is empty but hash table lookup is constant so we won't gain anything from that so it doesn't make sense to add extra code for that.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/797#issuecomment-190222139
