Looks mostly good by quick inspection. But you give me an opportunity to ask what I mostly missed on U-CTags: why 0a99f9c39ae02a9501c439e8acf177f958f949bb? I mean, I get some of the additions, but not most of the changes, that were originally made for a reason, like the separate *mem.c*/*file.c* which was here to compartiment the backends and make the code easier to work with (originally it had the if/else style, but I [went away from it](/b4n/mio/commit/f7f97f60f4b80128cf8a929d75a78b3a4ad90e0b)). Same, dropping GLib dep is nice for CTags, but instead of re-doing it, [upstream](/b4n/mio/) [has it](/b4n/mio/commit/08cc254fe29eee09ff28ac8b503e9f84a092c2af), and it's not a totally trivial change as a full MIO implementation requires a *conformant* `vsnprintf()`, which is not so uncommon but basically requires a conformant C99 implementation. I'm not even sure MSVC has one (current docs seem to say it does though, but `vsnprintf()` return value seem to have always be a problem on MSVC).
And if you wanna diverge too far from upstream (which is the case apparently, also changing style and whatnot), that one should die and all the tests should be imported into the new upstream. I don't really care what is upstream as I doubt anything else than Geany (and now CTags) use it, but it should then die in favor to becoming a part of CTags itself. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1070#issuecomment-225580487
