> Ah nice, didn't spot this. Even better yet Surely duplicating a handful of strings once isn't going to hurt :)
> But yeah, the cast could be done the other way around in the g_free() call > instead of the assignation. Could also remove the cast entirely if it used the same ownership semantic for all key groups. Trades a teeny bit of performance for a small code perfume :) Otherwise it looks OK, assuming no plugins do weird things like identity (pointer) compares with the keygroup names assuming they're going to be the ones they passed in. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1126#issuecomment-231257547
