> I don't dislike the cast enough to pay the performance penalty.

What was the speedup with the cast when you profiled it? :) Cast is evil, 
especially casting away const-ness. It's entirely possible that pulling a 
handful of free links of the allocators free list is less costly than the lost 
optimizations after the compiler throws up its hands when seeing a dangerous 
cast.

That said, I don't really care, I just doubt that copying a dozen strings once 
at startup should be considered a performance hit and optimized at the cost of 
code clarity/quality (notice @elextr asked about it first thing, since it's 
weird).

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1126#issuecomment-231354089

Reply via email to