Not sure I totally agree that its better to not save at all if the rename fails, all that happens IIUC is an old file is left behind, the new data is still saved at the new location and the Geany buffer points to it. Better to save the buffer for safety, and then let the user handle the leftovers.
On Windows renames fail when the old file is in use. On Linux renames across file systems fail. So its quite possible that the rename fails and the save succeeds. Also the change of `document_rename_file()` to return a value will need an API bump and an ABI bump. IMHO this isn't important enough to cause an ABI bump, it should be delayed until the next one happens. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1180#issuecomment-240680026
