The reason that the save should go ahead is because the operation being 
performed is "Save As".  The rename function is only a secondary convenience 
function to save deleting the original file.

It is actually a poorly thought out function anyway.  Why rename the existing 
file if it is about to be overwritten?  And if you have "safe" or "GIO" file 
saving set the sequence is "rename original file, write new data to a new file, 
rename it over the just renamed original file" :-P

The "Save As" dialog should offer to "Remove original file after saving".  And 
delete the original file after saving.  Then its obvious that a failure of 
removal due to permissions, or any of the reasons given above, has not affected 
the main function to "Save As".  And on save failure the original file is 
unharmed.  And on Linux there is no restriction to the same filesystem when 
selecting the option.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1180#issuecomment-240932680

Reply via email to