> It looks to me like we can remove the auto_reload option and make it automatic without data loss.
I agree, but for the moment it's probably wise to keep it as is since it may cause high-memory usage. > Am I correct in assuming you would prefer a finer-grained version of > file_prefs.keep_edit_history_on_reload ? No, it should be fine if it does what it sounds like. I thought there was only "show_keep_edit_history_on_reload_msg". The only potential change I can think might be to change the default enabled/disabled state of it, or perhaps making it mutually exclusive with the new auto_reload option. > If so, perhaps document_reload_force() and document_open_file_full() could be refactored to take a keep_undo_history parameter? I haven't looked at this code enough to say yet, I will have a look when I test this PR out. > I do not consider changing the file monitor to be a part of this PR. Agree. I will check how it behaves with the changes in this PR while testing it, but it's basically unrelated at this point. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1246#issuecomment-250634630
