> > Ok, well, unless @shiftee wants to make it so, thats not part of this PR > Why is dealing with bad interactions between features not part of a PR unless > the submitter (solely) wants to make the change?
The submitter can always say they don't want to do something, thats always their choice. Not doing something may affect the chances of the PR being accepted, but its always the submitter's choice. I have said I don't think it should affect the chances, and you have said you disagree, so its up to somebody else to determine then. > > But until its done the default should be off. > I agree, but it can be done as part of this PR if we want to, by anyone, and > is far simpler to do than the testing of this feature with all the related > features/options will be before merging, so if nobody beats me to it, I might > just do it myself while testing. Of course you can make another PR with the extra functionality, thats the point of open source. :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1246#issuecomment-249753296
