> - GRegex vs GNU regex - I kept GRegex in lregex.c (but synced all the rest) > but we should think whether not to convert back to GNU regex
Well… I'd rather not bundle yet another library, especially as we have the same feature already available in a dependency. > - isIgnoreToken() works differently than in uctags. Does it? Isn't just the API different? > If it simply just dropped certain tags, we could move the logic into TM but > right now, it helps the C parser with parsing by suggesting whether the > contents of braces should be dropped too. I'm not sure if we need to preserve > this functionality (never used the ignored.tags file myself) but if we move > to the new cxx parser we'd have to keep this diff unless there's some > interest for this in uctags. Well, the point of ignore tokens is to mitigate the confusion macros can cause on the C parser. For example, I have a custom ignore.tags with those: ``` G_GNUC_DEPRECATED_FOR+ G_GNUC_PRINTF+ G_GNUC_SCANF+ G_GNUC_FORMAT+ G_GNUC_* ... __STL_NOTHROW __THROW GIT_EXTERN=extern cairo_public GEANY_DEPRECATED GEANY_PRIVATE_FIELD GEANY_DEPRECATED_FOR+ ``` so various source files parse a lot better, because the parser just performs as if those weren't part of the source. See it as the poor man's C preprocessor. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1263#issuecomment-262809493
