> The great majority of the added code is nothing useful for Geany (processing 
> command-line parameters of ctags, support of different output file formats, 
> etc.). The only useful thing which this patch brings is the mentioned cork 
> thing and the ability to run nested parsers from within another parser. 
> Adding this would be less than 1000 LOCs (rough estimate).

That was what I suspected.

> 1. Syncing parsers.
> 2. If possible getting rid of Geany-specific code we still have.
> 3. Bringing the library support to ctags.
> 4. Refactoring ctags so only the necessary things compile for a library.

I suggest doing it in reverse order, wait until ctags is made into a library 
then do one change when it has a stable API.  Bringing in all the unused crap 
and then removing it and interfacing Geany to whatever the ctags API is gonna 
be is wasted work IMO.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1263#issuecomment-254949102

Reply via email to