@elextr why should a comment on a line in the diff (not a "review" comment 
even), specifically stating that I know it's not caused by this PR (neither 
@b4n nor I said it was _unrelated_), stall the PR, even though I made a point 
of adding a PR-level comment that it looks OK? The thing that stalls (or at 
least confuses) PRs is off-topic discussion in the PR-level thread (like this).

Moreover, if a bug is noticed within a few lines, and directly affected by the 
changes in the PR, it's not really a separate issue/PR (PRs can have more than 
one commit), if the pull requester feels like fixing the code in the same PR, 
seeing as it touches the same code.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1561#issuecomment-318231655

Reply via email to