b4n commented on this pull request.


> -     if (! gtk_builder_add_from_file(builder, interface_file, &error))
+       ui_data = g_resource_lookup_data(geany_get_resource(),
+               "/org/geany/Geany/geany.glade", G_RESOURCE_LOOKUP_FLAGS_NONE, 
&error);
+       if (ui_data == NULL)
+       {
+               dialogs_show_msgbox_with_secondary(GTK_MESSAGE_ERROR,
+                       _("Geany cannot start!"), error->message);
+               g_error("Cannot load user-interface: %s", error->message);
+               g_error_free(error);
+               g_object_unref(builder);
+               return;
+       }
+
+       error = NULL;
+       if (gtk_builder_add_from_string(builder, g_bytes_get_data(ui_data, 
NULL),
+               g_bytes_get_size(ui_data), &error) == 0)

Well, the thing is that from what I understand from the API, it actually has 
the semantics of a boolean, it seems like the actual value has literally *no* 
meaning apart from success/failure.  I didn't check the code yet, but AFAICT 
the documentation doesn't say anything about any use for it, and there's no API 
that would use the returned value.  But anyway, it doesn't really matter to me 
either way.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1703#discussion_r154512050

Reply via email to