b4n commented on this pull request.
> @@ -42,6 +42,7 @@ #include "msgwindow.h" #include "prefs.h" #include "project.h" +#include "resources.h" not needed > + --target=$@ \ + --sourcedir=$(srcdir) \ + --generate-source \ + --c-name="geany" \ + --manual-register \ + --internal \ + $(srcdir)/geany.gresource.xml +resources.h: $(resource_dependencies) + $(AM_V_GEN)$(GLIB_COMPILE_RESOURCES) \ + --target=$@ \ + --sourcedir=$(srcdir) \ + --generate-header \ + --c-name="geany" \ + --manual-register \ + --internal \ + $(srcdir)/geany.gresource.xml Hum, maybe you need to add something like `|| rm -f $@` (but you need to still return in error) so that if the generation fails for some reason it will be tried again next time. Another common solution is to generate a temporary file and move it over on success, so it's mostly atomic. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1703#pullrequestreview-80691373
