b4n requested changes on this pull request.
More to come
> @@ -19,8 +19,8 @@ AC_DEFUN([GP_CHECK_WEBHELPER],
fi
fi
- GP_CHECK_GTK3([webkit_package=webkitgtk-3.0],
- [webkit_package=webkit-1.0])
+ GP_CHECK_GTK3([webkit_package=webkit2gtk-4.0],
+ [webkit_package=webkit2gtk-4.0])
that's wrong, webkit2gtk-4.0 don't work with GTK2
> @@ -49,8 +49,8 @@ AC_DEFUN([GP_CHECK_MARKDOWN],
GTK_VERSION=2.16
WEBKIT_VERSION=1.1.13
- GP_CHECK_GTK3([webkit_package=webkitgtk-3.0],
- [webkit_package=webkit-1.0])
+ GP_CHECK_GTK3([webkit_package=webkit2gtk-4.0],
+ [webkit_package=webkit2gtk-4.0])
same that with WebHelper, webkit2gtk-4.0 is wrong for GTK2
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/677#pullrequestreview-89679247
