On Wed, Jan 17, 2018 at 09:28:48PM +0000, Colomban Wendling wrote: > @hyperair I'd like to keep GTK2 support on WebHelper if possible, and I know > I've started (but not finished) this somewhere, I'll try to find it, compare > with your changes and see if I find it reasonable to have support for both, or > if you're right and it would be too much of a hassle. Also, if Debian is also > switching to GTK3 Geany, it might suggest no distro is still using the GTK2 > one and that it might be time to let go of the most complex GTK2 > compatibility. I'll see.
I've already switched the Geany package in Debian to gtk3. Unfortunately, the new plugins package is still stuck in NEW. I'll update the PPA shortly after I finish working on this port too. If you want to keep gtk2 after all, elextr's suggestion of splitting the plugin into separate gtk2 and gtk3 versions might make sense. > And thanks for your work here, looks promising :) :) Thanks, good to know. > Anyway, it'd be nice to split this PR in 2, one for each plugin, especailly as > it's 2 separate maintainers that might have different views on supporting GTK2 > or not :) I thought about doing that at first, but I suspect that there may be symbol clashes between webkitgtk-1.0 and webkit2gtk-4.0, so loading plugins using different webkit libraries into the same instance of Geany may end badly. -- Kind regards, Loong Jin -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/677#issuecomment-358566833
