codebrainz commented on this pull request.
> + vbox = gtk_widget_get_ancestor(page, GTK_TYPE_VBOX);
+ GList *vbox_children = gtk_container_get_children(GTK_CONTAINER(vbox));
+ GtkWidget *sbox;
+ if (interface_prefs.search_bar_position == SEARCH_BAR_POSITION_TOP)
+ {
+ sbox = (GtkWidget*)vbox_children->data;
+ }
+ else
+ {
+ sbox = (GtkWidget*)((GList*)g_list_last(vbox_children))->data;
+ }
+ g_list_free(vbox_children);
+ return sbox;
+}
+
+void
ui_emit_entry_what_to_search_in_search_bar_changed_if_visible(GeanyDocument
*doc)
:astonished:
Not to bikeshed, but it might be useful to spend some of those characters
explaining what `sbox` is inside the function. Perhaps it could be shortened to
`ui_emit_search_bar_entry_changed`? Likewise for below, it could be something
like `ui_emit_search_bar_close_button_clicked`. While I'm a big fan of
descriptive function names, it doesn't necessarily have to say everything the
function does.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2220#pullrequestreview-267453776
