> Requiring the user to discover and enable plugins for even the most basic
> enhancements degrades Geany itself, and makes the plugin manager become a
> mess.
You're making an argument that the current UX for plugins sucks, not that this
PR specifically shouldn't be a plugin.
> Plus, those "just add one tiny enhancement" plugins are often fire-and-forget
> and become orphaned and unmaintained.
So dumping all of those unmaintained fire-and-forget codes into core is better?
> Plugins should add complex functionality that the core devs aren't up to
> maintain. Having tons of micro plugins is worse overall than just adding
> 50-100 LOCs to the core (ideally along with some unit tests).
Not IMO. Aside from the friction to install/update/remove plugins, there's not
really any good reason not to have nearly everything in plugins. As mentioned,
this isn't a reason to bring a bunch of plugins into core functionality, it's a
reason to improve the plugin experience.
Anyway, I'm not opposed to doing what the PR title says ("Replace search dialog
with search bar"), I'm just opposed to adding _another_ search UI in addition
to what exists, hidden behind a preference. If the search bar is truly superior
to everyone, then we should remove the search dialog and replace it with the
search bar, otherwise, it ought to be a plugin, IMO.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2220#issuecomment-515811956
