elextr commented on this pull request.


> @@ -2577,15 +2565,20 @@ void build_save_menu(GKeyFile *config, gpointer ptr, 
> GeanyBuildSource src)
                                g_key_file_remove_key(config, build_grp_name, 
"error_regex", NULL);
                        if (pj->priv->build_filetypes_list != NULL)
                        {
-                               data.config = config;
-                               data.ft_names = g_ptr_array_new();
-                               
g_ptr_array_foreach(pj->priv->build_filetypes_list, foreach_project_filetype, 
(gpointer)(&data));
-                               if (data.ft_names->pdata != NULL)
+                               GPtrArray *ft_names = g_ptr_array_new();
+                               guint i;
+                               
+                               foreach_ptr_array(ft, i, 
pj->priv->build_filetypes_list)

Agree with @codebrainz lower case local macros is BAD, please don't perpetuate 
the evil Geany already has.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2270#discussion_r316935451

Reply via email to