codebrainz commented on this pull request.
> @@ -219,6 +219,10 @@ Coding ``gint``, use a ``gchar`` for individual (ASCII/UTF-8) string characters rather than ``gint``, and use a ``guint`` for integers which cannot be negative rather than ``gint``. +* Avoid using untyped pointers (e.g. gpointer) where practical. +* Prefer loops to calling *_foreach() with a non-NULL untyped + ``user_data`` pointer parameter, unless external iteration is not + supported (e.g. for tree structures). This is a bit confusing IMO. Maybe it would read better by just dropping the `with a non-NULL untyped user_data pointer parameter`? Even without that part, it's still a useful guideline and not overly specific. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2270#pullrequestreview-279267778
