codebrainz commented on this pull request.
> @@ -2577,15 +2565,20 @@ void build_save_menu(GKeyFile *config, gpointer ptr,
> GeanyBuildSource src)
g_key_file_remove_key(config, build_grp_name,
"error_regex", NULL);
if (pj->priv->build_filetypes_list != NULL)
{
- data.config = config;
- data.ft_names = g_ptr_array_new();
-
g_ptr_array_foreach(pj->priv->build_filetypes_list, foreach_project_filetype,
(gpointer)(&data));
- if (data.ft_names->pdata != NULL)
+ GPtrArray *ft_names = g_ptr_array_new();
+ guint i;
+
+ foreach_ptr_array(ft, i,
pj->priv->build_filetypes_list)
> But what about things that people often get wrong, like not checking
> doc->is_valid, I think the foreach_document macro is worth having. is_valid
> is a Geany-specific thing, so it's easy to justify a macro here. Sure, make
> it upper-case though.
If there's an actual reason for it, sure. But what is the reason we keep
invalid documents around? If there is a good reason to do that (like not
premature optimization), I would tend to agree such a macro may be useful, but
probably located in the `document.h` file and as we all agree upper-case.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2270#discussion_r317370461
