> It's a little stupid Geany uses the hard-coded /bin/sh inside build.c.

I dislike hardcoding as well, but on a properly configured system, AFAIK, 
`/bin/sh` should refer to a POSIX compatible shell (be it bash, dash, etc.), so 
it's not totally unreasonable for Geany to use it.

> Any objections if I make this configurable inside the Various section and 
> make it default to /bin/bash for macOS?

None here.

I didn't look into it much, but I noticed there's already [a hack for 
same/similar 
issue](https://github.com/geany/geany/blob/75def8a24eb2dab8d376ae051806128827d34fbe/src/keyfile.c#L888)
 in the VTE code that might be worth re-visiting when making the changes, or 
just copy and paste that code again :smile:

It might be nice in the future to make the Shell configurable in the Tools tab 
and have it inherited by the arguments used for the "Terminal" command 
arguments in that tab, the "Shell" command in the VTE preferences, and anywhere 
else that uses a shell too.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2344#issuecomment-542454891

Reply via email to