> @techee IIUC the problem is with tag files that have CRLF line endings, not 
> source files getting parsed. If that's so, it won't change nothing there, at 
> worse we need special handling to support CRLF and LF not to break 
> compatibility.

Maybe I miss something but that's not my impression with the failed SQL tests - 
it's the tests themselves that have CRLFs in the code and the tag file diff is 
this based on Enrico's output. There are several tags missing and I think the 
missing tags are caused by the CRLFs in the test:

```
--- ./ingres_procedures.sql.tags        2016-06-12 17:16:40.683765400 +0200
+++ /tmp/tmp.2xGTegTO88/test.sql.tags   2020-11-25 23:33:27.945656500 +0100
@@ -1,7 +1,3 @@
 # format=tagmanager
 db0001Ì256Ö0
-db0002Ì256Ö0
-db0003Ì256Ö0
-errÌ16384Ö0
-nÌ16384Ö0
 xÌ16384Ö0
FAIL ingres_procedures.sql.tags (exit status: 2)
```



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2666#issuecomment-735724637

Reply via email to