Guys, don't panic :). Maybe I wasn't clear above: I do *not* want to change the line endings of any input files! In my tests, it didn't matter if the input file had LF or CRLF line endings, the generated tags were correct.
I was just talking about converting the unittest tags files against we compare the generated tags files. I agree that the diffs look confusing but as said earlier with the binary mode change for writing tags files, we ensure that the generated tags files always have LF line endings and so IMO it should be fine to also convert the pre-generated tags files for the unittests. To me, it doesn't seem as we have a major problem on Windows with the tags files. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2666#issuecomment-736104834
