> The test problem looks like you have a gap between the name and the data in > the reference tags file, whereas AFAICT all others do not have that. So > probably your code is right and the test is wrong ;-P
Oooh, that was it :) So yeah, the example `matlab_test.m` file included a space at the end of each function, like `function func3 `, which the previous (erroneous) parser was including as part of the function name, since it parses everything from the first non-whitespace after `function` to the end of the line (or beginning of comment), and the test was tailored to make that work. Anyway, all tests pass now :) Maybe I should add a few extra lines to that test with some of the new corner cases I'm now capturing, like the case with `=` in a comment. As per the level of support for regular expressions, I see no other ctags parser using `tagRegexTable`, so I'm not sure it's supported. (But even if it is, I'm not sure it's a good idea to use it only for Matlab.) PS: I have no idea how to write ctags parsers and have just been blindly modifying what geany_matlab.c did. I notice that other tests have a much more complex .tags file which seems to include an argument list, probably for autocompletion hints. My commit only addresses the sidebar and ctrl-click thing; maybe the proper fix would be to use these more advanced features, but I'm not at that level yet... -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3358#issuecomment-1364792417 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany/pull/3358/[email protected]>
