> I didn't examine the code carefully for when its used, but I noticed > [goto-tag](https://github.com/geany/geany/blob/d54b2a899dca95639fa6f52d5e16034498c332d9/src/symbols.c#L1648) > has > [document_open](https://github.com/geany/geany/blob/d54b2a899dca95639fa6f52d5e16034498c332d9/src/symbols.c#L1696) > and so does the popup_item_activate() when a list is displayed so I assumed > that it did open the file, or at least there is an intention to open > documents if the tag has a filename even if it doesn't work?
Alright, I was wrong then, Geany really opens the file. Anyway, we still need to store the path of global tags somewhere in the Geany's memory representation and it would be better to store it directly in TMTag than to TMSourceFile which is used for "dynamic" files like an editor that gets re-parsed every time the user writes something and is used for removing the original tags with the new tags. Global tags, instead, stay in the workspace unchanged since they get loaded. > With all due respect to your adopted baby, I personally would prefer to throw > the binary, Unicode dangerous, tagmanager format under a truck and use > e/ctags format, even if it means using e/ctags to write the files. I don't really have any problem with that and I think in principle we actually should do that, I'd just keep the old tag file format for compatibility (it's also useful for our unit tests because it reveals to which internal). I was also thinking we might add some basic escaping for characters `\200`-`\215` to avoid the unicode problems. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3379#issuecomment-1407634346 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany/issues/3379/[email protected]>
