@techee commented on this pull request.


> +     if (sci_get_line_from_position(sci, pos_next) == line)
+               char_width = SSM(sci, SCI_POINTXFROMPOSITION, 0, pos_next) - x;

> This is with the current state of this PR right, not with just char_width=0, 
> is it?

Yes it is (to be precise, with `char_width=1`, I wasn't sure if 0-width 
bounding box works alright in this case).

> The problem with the current version is only if you have wrapping enabled and 
> it wraps after the next character (e.g. if wrapping wrapped right after the i 
> (not even having the space after). What you'd see is the popup on the far 
> left of the editor.

I understand the current version problem but I still don't see the problem with 
`char_width=0`.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3316#discussion_r1352355275
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3316/review/1667483...@github.com>

Reply via email to