@b4n commented on this pull request.


> +     if (sci_get_line_from_position(sci, pos_next) == line)
+               char_width = SSM(sci, SCI_POINTXFROMPOSITION, 0, pos_next) - x;

I guess I feel like the popup should be under the letter the caret is at (not 
sure what are the real differences between having the caret over or before a 
character though, offsets should be pretty much the same… but this is kind of 
irrelevant to the feel :))

> But don't hesitate to implement it your way if this is something that bothers 
> you :-).

You nailed it I guess :D

I went ahead and implemented the more basic version that is similar to what was 
there but don't produce incorrect results on the wrapping corner case.  So I'm 
happier, and you're not too unhappy because it's not as complicated as it could 
be :grin: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3316#discussion_r1357412991
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3316/review/1675185...@github.com>

Reply via email to