> > I wrote most of it, it ought to be perfect 😁
> 
> Oh, I'm syncing it in the wrong direction - I should have updated ctags with 
> your code :-).

Meh, I also wrote some of that one, so either way works :grinning: 

> I discovered one more problem - all parsers use `typeref:typename` but I just 
> discovered after looking at Enrico's php tags file and at the php parser 
> afterwards that php uses `typeref:unknown` for typenames for some reason. So 
> I updated the code to allow `unknown` behind `typeref` too.

Good catch.  Maybe it'd be worth submitting an update to that parser to be more 
in line with the convention as well.

> Maybe should I also grab the latest version of the libreadtags library for 
> this PR? I noticed you also submitted some patch to it in the spring.

I didn't check the diff, but my latest changes there were not crucial, they 
fixed C stdlib usage, and some very theoretical issues handling some non-ASCII 
bytes.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3049#issuecomment-1759182634
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3049/c1759182...@github.com>

Reply via email to