@b4n commented on this pull request.
Looks fairly useful and simple enough :+1:
Apart from my inline comments, LGTM and WFM.
> + gtk_container_add(GTK_CONTAINER(menu), item);
+ gtk_menu_reorder_child(GTK_MENU(menu), item, 0);
```suggestion
gtk_menu_shell_prepend(GTK_MENU_SHELL(menu), item);
```
> - /* put entries with submenus at the end of the menu */
+ /* put entries with submenus at the start of the menu */
if (gtk_menu_item_get_submenu(item_a) &&
!gtk_menu_item_get_submenu(item_b))
- return 1;
- else if (!gtk_menu_item_get_submenu(item_a) &&
gtk_menu_item_get_submenu(item_b))
return -1;
+ else if (!gtk_menu_item_get_submenu(item_a) &&
gtk_menu_item_get_submenu(item_b))
+ return 1;
This confused me because it's already in #3397, so it's actually *not* part of
this PR anymore. But :+1: anyway.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3396#pullrequestreview-1681037011
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3396/review/[email protected]>
