Looking at the Automake-based Linux build logs here: ``` <snip> PASS: test_utils SKIP: test_sidebar ============================================================================ Testsuite summary for Geany 2.1 ============================================================================ # TOTAL: 2 # PASS: 1 # SKIP: 1 # XFAIL: 0 # FAIL: 0 # XPASS: 0 # ERROR: 0 ============================================================================ <snip> ```
And from the Meson-based Linux build log: ``` <snip> 349/351 ctags/processing-order OK 0.07 s 350/351 utils OK 0.02 s 351/351 sidebar SKIP 0.02 s Ok: 350 Expected Fail: 0 Fail: 0 Unexpected Pass: 0 Skipped: 1 Timeout: 0 Full log written to /home/runner/work/geany/geany/_build/meson-logs/testlog.txt ``` So GTK initialisation fails (as expected, due to the headless environment) and the proposed change is working as intended with both build systems. Making display-requiring tests work in CI would call for something like Xvfb, or a more modern alternative based on a headless Wayland/XWayland server, as mentioned in the linked issue. But `gtk_init_check`'s return value should still be properly acted upon in this case. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3676#issuecomment-1796529112 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany/pull/3676/[email protected]>
