@b4n requested changes on this pull request.
Looks reasonable, at least better than the finger crossing we had before.
However, skipping the test is clearly not ideal, and using xvfb-run/xwfb-run
would probably be better, but might be OK as a future improvement.
> + if(!gtk_init_check(&argc, &argv)) {
+ g_test_message("%s", "GTK initialisation failed; skipping.
Running inside a headless environment?");
+ return 77;
+ }
```suggestion
if (! gtk_init_check(&argc, &argv))
{
g_test_message("GTK initialization failed; skipping. Running
inside a headless environment?");
return 77;
}
```
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3676#pullrequestreview-1778548604
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3676/review/[email protected]>
