@eht16 commented on this pull request.
> @@ -418,7 +418,7 @@ static unsigned int re_string_context_at (const > re_string_t *input, int idx, #define re_string_skip_bytes(pstr,idx) ((pstr)->cur_idx += (idx)) #define re_string_set_index(pstr,idx) ((pstr)->cur_idx = (idx)) -#ifdef WIN32 +#ifdef _WIN32 I couldn't find any reference to this in uctags and so assumed, it's our own copy without upstream. And in https://github.com/geany/geany/pull/3660#issuecomment-2121229911 you said basically the same, didn't you? If I'm not completely wrong, I'd say this is OK except we intend to upstream this code ever again or, as you also said, replace it the gnulib implementation which uctags uses. Though this feels like a whole another story :(. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3878#discussion_r1607320372 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany/pull/3878/review/[email protected]>
