@eht16 commented on this pull request.
> @@ -418,7 +418,7 @@ static unsigned int re_string_context_at (const > re_string_t *input, int idx, #define re_string_skip_bytes(pstr,idx) ((pstr)->cur_idx += (idx)) #define re_string_set_index(pstr,idx) ((pstr)->cur_idx = (idx)) -#ifdef WIN32 +#ifdef _WIN32 It's ``` 344K geany/ctags/gnu_regex ``` vs ``` 1.4M ctags/gnulib ``` If size matters. Since we use it probably mainly only for Windows, maybe it does not matter. PR https://github.com/universal-ctags/ctags/pull/3054 introduced the gnulib version and argues that the glibc version is too old, related issues also state that it is slow. I can't verify if this is also true for Geany but I would guess since we use uctags' parsers, it might be. @elextr's last comment reads like we already agreed on doing "that update"? :D OTOH it might cause quite some work for a small benefit. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3878#discussion_r1610394852 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany/pull/3878/review/[email protected]>
