One more thing. The plugin should pre-fill
`default_persistent_temp_files_dir_utf8` into the directory entry in the plugin
configuration. When you delete the saveactions configuration file, this entry
is empty by default.
Also, when this empty directory gets confirmed, the plugin shows a dialog with
error, but this invalid value is stored into the config file anyway (I know
this is how the Instantsave feature has it implemented now and you just copied
it from there, but it shouldn't be possible to confirm the save action
preferences with the invalid value and the preferences dialog shouldn't be
closed in this case).
Finally, when you confirm the empty directory entry, the plugin crashes in
```
#1 0x0000ffffec113d54 in is_temp_saved_file
(file_path_utf8=0xaaaaab716d80
"/home/parallels/projects/geany/doc/plugins.dox") at saveactions.c:336
#2 0x0000ffffec113eb4 in persistent_temp_files_update (data=<optimized out>)
at saveactions.c:733
```
This should be fixed too.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3911#issuecomment-2192691908
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3911/[email protected]>
