so i reworked settings behavior for this feature, now everything should be fine: - when geany starts without existing temp files dir setting or settings file - it populates default dir path setting and creates folder on disk - when geany starts with existing dir setting that is invalid (e.g. folder was deleted manually) - feature gets auto-disabled and status message sent. - when user tries to save feature settings - dialog wont close until valid dir is set (or 'cancel' clicked). - enabling feature with invalid dir path in a textbox is also not possible anymore.
also, i fulfilled old TODO of instantsave code i reused and added one of utils function to plugins API (checking if file is writable) Overall, now everything seems working fine to me. As it is expected - doing any changes in C may be hilariously tedious, and current code will anyway have to be re-wired to new UI (if we want it to change), so i guess we need to confirm an approach and then (if this happens) - try to finish everything. e.g. this looks good to me https://github.com/geany/geany/pull/3911#pullrequestreview-2136554129 -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3911#issuecomment-2197713722 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany/pull/3911/[email protected]>
