@b4n commented on this pull request. LGTM from little review and testing apart from: * the comment about the patch file * the absence of tags parsing. the custom filetype version uses Java, which seems to do a decent job (beware that not knowing the language, I just copied a couple of samples and lanced at the results), should this one do the same?
> @@ -84,6 +84,7 @@ index cd4b23617..af4a73db4 100644 + &lmCPP, + &lmCss, + &lmD, ++ &lmDart, As this isn't updating the chunk header, it's gonna corrupt the patch, isn't it? > @@ -84,6 +84,7 @@ index cd4b23617..af4a73db4 100644 + &lmCPP, + &lmCss, + &lmD, ++ &lmDart, …well OK, it's already broken since at least a9363bc15d2c66ea91eeec923961f93e41bff216, but is that an excuse? :) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3973#pullrequestreview-2350602121 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany/pull/3973/review/[email protected]>
